[webkit-reviews] review granted: [Bug 43120] [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member variable so any attempt to append strings to a WebDOMStringList instance results in a crash. : [Attachment 62824] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 43120: [IndexedDB] WebDOMStringList default ctor does not initialize its
m_private member variable so any attempt to append strings to a
WebDOMStringList instance results in a crash.
https://bugs.webkit.org/show_bug.cgi?id=43120

Attachment 62824: Patch
https://bugs.webkit.org/attachment.cgi?id=62824&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js:37
 +	shouldBe("storeNames.contains('storeName')", "true");
Maybe also check that there's only this one item?

WebKit/chromium/public/WebDOMStringList.h:49
 +	WebDOMStringList();
I'd lean towards making this private and have 2 factory methods instead:
"createEmpty" and "createNull".  Though since no one needs the "null" behavior
today, I'm OK with you leaving this as is.

me