[webkit-reviews] review granted: [Bug 43116] [IndexedDB] IDBKeyRange should be a runtime-enabled feature. : [Attachment 62815] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 05:34:09 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 43116: [IndexedDB] IDBKeyRange should be a runtime-enabled feature.
https://bugs.webkit.org/show_bug.cgi?id=43116

Attachment 62815: Patch
https://bugs.webkit.org/attachment.cgi?id=62815&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
r=me because this fixes a regression

But I'm not sure I like the idea of us adding a bunch of methods which simply
just return whether indexedDB is enabled.  I think I'd rather see
EnabledAtRuntime optionally take an argument that tells it what function to
call.  So this would be EnabledAtRuntime=indexedDB


More information about the webkit-reviews mailing list