[webkit-reviews] review denied: [Bug 43015] dump-as-markup should have better output : [Attachment 62778] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 43015: dump-as-markup should have better output
https://bugs.webkit.org/show_bug.cgi?id=43015

Attachment 62778: Patch
https://bugs.webkit.org/attachment.cgi?id=62778&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Very cool.  Thanks for doing this.  Unfortunately, we can't change the format
of the html5lib test expectations.  These data files are just a copy of the
"official" ones at
<http://code.google.com/p/html5lib/source/browse/#hg/testdata/tree-construction
>.  The data format in them is chosen to work with a number of different HTML5
parsers in a bunch of different languages (including many that don't execute
JavaScript).

Can we keep the new dump-as-markup but leave the HTML5lib test suite using the
"old and busted" dom2string?  Alternatively, we could dump-as-markup produce
identical dumps for the HTML5lib test suite, but that might constrain our
ability to make dom-as-markup more awesome in the future.