[webkit-reviews] review requested: [Bug 25677] [GTK] Implement support for get_character_extents and get_range_extents : [Attachment 62755] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25677: [GTK] Implement support for get_character_extents and
get_range_extents
https://bugs.webkit.org/show_bug.cgi?id=25677

Attachment 62755: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=62755&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a new patch to address this issue, based on the original one provided
by Joanmarie + addressing the following issues:

  - Adapted code to work with all the changes that have happened since the
original one was written, that is, as Joanmarie calls it... The Great
Flattening (I love this name) :-)
  - Adapted unit tests in the testatk.c file to test the
get_character_extents() and get_range_extents() functions for the AtkText
interface, after all the changes that were done
  - Checked how it works with non "pure text" node, such as links, headings,
groups or webareas

Eager to read some feedback on it, but now time to go to bed.

Greetings from GUADEC!