[webkit-reviews] review granted: [Bug 42999] Add a Chromium WebKit API for drawing text : [Attachment 62741] Patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 27 14:06:28 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Brett Wilson
(Google) <brettw at chromium.org>'s request for review:
Bug 42999: Add a Chromium WebKit API for drawing text
https://bugs.webkit.org/show_bug.cgi?id=42999

Attachment 62741: Patch v4
https://bugs.webkit.org/attachment.cgi?id=62741&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebFont.h:51
 +	WEBKIT_API static WebFont* Create(const WebFontDescription&);
nit: Create -> create

WebKit/chromium/public/WebFont.h:70
 +	// run to draw. If |to| is -1, the enture run will be drawn.
nit: enture -> entire

WebKit/chromium/public/WebFont.h:87
 +	// |leftBaseline| position. |h| indicates the height of the selection
rect
nit: h -> height

WebKit/chromium/public/WebTextRun.h:43
 +	WebTextRun(const WebString& t, bool isRtl, bool hasDirectionalOverride)

nit: isRtl -> isRTL so this can compile :-)

WebKit/chromium/src/WebTextRun.cpp:40
 +  WebTextRun::operator WebCore::TextRun() const
nit: no need for WebCore:: prefix

R=me with those nits fixed


More information about the webkit-reviews mailing list