[webkit-reviews] review granted: [Bug 42915] Add FILE_SYSTEM build flag for FileSystem API : [Attachment 62469] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 27 13:17:11 PDT 2010
Ojan Vafai <ojan at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 42915: Add FILE_SYSTEM build flag for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=42915
Attachment 62469: Patch
https://bugs.webkit.org/attachment.cgi?id=62469&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Just a few nits about comments. Feel free to commit after fixing them.
FileSystem isn't a part of the HTML5 spec as best I can tell, so we should
refer to it as HTML5 FileSystem support, right?
> +++ b/configure.ac
> @@ -536,6 +536,14 @@ AC_ARG_ENABLE(directory_upload,
> [], [enable_directory_upload="no"])
> AC_MSG_RESULT([$enable_directory_upload])
>
> +# check whether to enable directory upload support
Comment copy-paste. :)
More information about the webkit-reviews
mailing list