[webkit-reviews] review denied: [Bug 42099] Crash when iframe replaces its document through its parent during parsing : [Attachment 61253] the patch and test case

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Yong Li <yong.li.webkit at gmail.com>'s
request for review:
Bug 42099: Crash when iframe replaces its document through its parent during
parsing
https://bugs.webkit.org/show_bug.cgi?id=42099

Attachment 61253: the patch and test case
https://bugs.webkit.org/attachment.cgi?id=61253&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
1) Have you tested whether this happens synchronously in other browsers in this
case?

2) It's pretty nutty to have script execution either be synchronous or not
depending on whether the parser is running.  The parser is designed to be
robust to executing JavaScript while it's on the stack.

3) What about other ways of executing JavaScript URLs synchronously besides
SubframeLoader::requestFrame?

I think it's kind of rude to reset the r? flag because you assume you're right.
 The more usual way to proceed is to discuss the issue and either renominate
the patch or upload a new patch after we've reached a meeting of the minds.