[webkit-reviews] review denied: [Bug 42403] [chromium] r63450 caused some svg mask tests to fail pixel tests : [Attachment 62705] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 27 11:23:41 PDT 2010


Ojan Vafai <ojan at chromium.org> has denied Alex Nicolaou
<anicolao at chromium.org>'s request for review:
Bug 42403: [chromium] r63450 caused some svg mask tests to fail pixel tests
https://bugs.webkit.org/show_bug.cgi?id=42403

Attachment 62705: Patch
https://bugs.webkit.org/attachment.cgi?id=62705&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
> +++
b/LayoutTests/platform/chromium-linux/svg/custom/mask-colorspace-expected.txt
This test is only failing the pixel results. You shouldn't need to add a
linux-specific text result.

> diff --git a/LayoutTests/platform/chromium/test_expectations.txt
b/LayoutTests/platform/chromium/test_expectations.txt
> +BUGWK42403 WIN WIN-XP WIN-VISTA MAC : svg/custom/mask-colorspace.svg = IMAGE


I know this is probably the rebaseline tools doing, but you only need to
include "WIN MAC" XP and VISTA aren't needed if you have WIN.


More information about the webkit-reviews mailing list