[webkit-reviews] review granted: [Bug 43052] [IndexedDB] Key range methods belong to the IDBKeyRange interface : [Attachment 62707] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 27 10:34:41 PDT 2010
Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 43052: [IndexedDB] Key range methods belong to the IDBKeyRange interface
https://bugs.webkit.org/show_bug.cgi?id=43052
Attachment 62707: Patch
https://bugs.webkit.org/attachment.cgi?id=62707&action=review
------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/page/DOMWindow.cpp:487
+ m_idb_key_range = 0;
not user hacker style
WebCore/page/DOMWindow.cpp:715
+
space isn't really necessary...but not super worried about it.
WebCore/page/DOMWindow.h:235
+ IDBKeyRange* iDBKeyRange() const;
Does casing it like this even work?
r=me
More information about the webkit-reviews
mailing list