[webkit-reviews] review denied: [Bug 42840] image element with src attribute can't be replaced by content: url() style : [Attachment 62327] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 27 08:38:45 PDT 2010


Adam Barth <abarth at webkit.org> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 42840: image element with src attribute can't be replaced by content: url()
style
https://bugs.webkit.org/show_bug.cgi?id=42840

Attachment 62327: Patch
https://bugs.webkit.org/attachment.cgi?id=62327&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Why is this a manual test?  Can't we see this with a render tree dump or a
pixel test?

WebCore/loader/ImageLoader.cpp:5
 +   * Copyright (C) Research In Motion Limited 2010. All rights reserved.
Please don't add your copyright when changing < 10 lines.

WebCore/rendering/RenderImage.h:7
 +   * Copyright (C) Research In Motion Limited 2010. All rights reserved.
ditto


More information about the webkit-reviews mailing list