[webkit-reviews] review granted: [Bug 40374] Client-based Geolocation does not pass high power option to controller and client : [Attachment 62681] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 27 06:25:32 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 40374: Client-based Geolocation does not pass high power option to
controller and client
https://bugs.webkit.org/show_bug.cgi?id=40374

Attachment 62681: Patch
https://bugs.webkit.org/attachment.cgi?id=62681&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/page/GeolocationController.cpp:61
 +		m_client->startUpdating();
Is there any reason this can't always be called?

WebCore/page/GeolocationController.cpp:74
 +	    if (m_observers.isEmpty())
Is there any reason this can't always be called?

r=me


More information about the webkit-reviews mailing list