[webkit-reviews] review denied: [Bug 42967] [IndexedDB] IndexedDatabase should be called IDBFactory. : [Attachment 62606] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 27 04:26:45 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has denied Andrei Popescu
<andreip at google.com>'s request for review:
Bug 42967: [IndexedDB] IndexedDatabase should be called IDBFactory.
https://bugs.webkit.org/show_bug.cgi?id=42967

Attachment 62606: Patch
https://bugs.webkit.org/attachment.cgi?id=62606&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
LayoutTests/storage/indexeddb/idb-factory.html:11
 +  <script src="script-tests/idb-factory.js"></script>
You need to sync.  This is no longer here.

WebCore/storage/IDBFactoryPrivateImpl.cpp:55
 +  PassRefPtr<DOMStringList> IDBFactoryPrivateImpl::databases() const
I really don't think we should mix new functionality with the renaming patches.



We need to discuss the naming of this stuff...


More information about the webkit-reviews mailing list