[webkit-reviews] review denied: [Bug 40374] Client-based Geolocation does not pass high power option to controller and client : [Attachment 62583] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 40374: Client-based Geolocation does not pass high power option to
controller and client
https://bugs.webkit.org/show_bug.cgi?id=40374

Attachment 62583: Patch
https://bugs.webkit.org/attachment.cgi?id=62583&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/page/GeolocationControllerClient.h:39
 +	// We should update the terminology used in WebCore to describe this
property
Add FIXME

WebCore/page/GeolocationController.cpp:77
 +		m_client->setEnableHighAccuracy(false);
You said "done" but this (and above) didn't change.

WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h:42
 +	void setEnableHighAccuracy(bool) { }
This should be the new terminology since it can't change easily once someone
implements it.

WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h:45
 +	virtual void setEnableHighAccuracy(bool) { }
ditto

WebCore/page/GeolocationControllerClient.h:41
 +	// http://www.w3.org/2008/geolocation/track/issues/6
Maybe suggest that webkit ports implementing it call it "highPower"