[webkit-reviews] review requested: [Bug 23556] On RTL pages, horizontal scrollbar is missing : [Attachment 62608] patch w/ layout test

[bugzilla-daemon at webkit.org]

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 23556: On RTL pages, horizontal scrollbar is missing
https://bugs.webkit.org/show_bug.cgi?id=23556

Attachment 62608: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=62608&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
The patch works for Chromium in 3 platforms, but it does not work well in MAC
port where ScrollView is a platformWidget.

The problem in MAC  port is:

For RTL page, the horizontal scrollbar should be at the very right when page is
loaded at first time. I am re-setting the scroll position in 
(void)setScrollOriginX:(int)scrollOriginX inside WebDynamicScrollBarsView.mm.
Please refer to FIXME in the file.
But apparently, it is not the right place to reset it.

Resetting the scroll position there makes the scroll position reset to its
original position for RTL page when page reload, page zoom, page resize, and
might also window.scrollX (although I do not understand why there is write
operation in this read-only access), which are all wrong. Please refer to the
FIXMEs in the layout test file.