[webkit-reviews] review denied: [Bug 41159] Come up with a more efficient way to represent Path segments : [Attachment 62600] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 41159: Come up with a more efficient way to represent Path segments
https://bugs.webkit.org/show_bug.cgi?id=41159

Attachment 62600: Patch
https://bugs.webkit.org/attachment.cgi?id=62600&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/svg/SVGGlyphElement.cpp:106
 +	SVGPathByteStream byteStream =
byteStreamBuilder.buildFromPathData(value);
Seems you meant an OwnPtr here.  This is not safe at all.

WebCore/svg/SVGPathByteStream.h:46
 +  class SVGPathByteStream {
This needs to be Noncopyable.

WebCore/svg/SVGPathByteStream.h:64
 +	size_t m_size;
Why not a vector?

WebCore/svg/SVGPathByteStreamBuilder.cpp:57
 +	unsigned char* bytes = new unsigned char[size];
Ick.  Vector, please.

Why do we want this?  How do we test this?  What's the observable benefit? 
Please write a test which shows the benefit.  If its memory usage, write a
manual test which we can evaluate memory usage from.