[webkit-reviews] review granted: [Bug 42771] Composited layers don't scroll in WebKit2 : [Attachment 62365] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 42771: Composited layers don't scroll in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42771

Attachment 62365: Patch
https://bugs.webkit.org/attachment.cgi?id=62365&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
> diff --git a/WebCore/rendering/RenderLayerCompositor.cpp
b/WebCore/rendering/RenderLayerCompositor.cpp
> index
234ad7f270191ef8a7ba5870b072d875bf6f7423..14d45927b3ca31cce19bce537343bbd90ccf8
553 100644
> --- a/WebCore/rendering/RenderLayerCompositor.cpp
> +++ b/WebCore/rendering/RenderLayerCompositor.cpp
> -void RenderLayerCompositor::updateContentLayerScrollPosition(const IntPoint&
scrollPosition)
> +void RenderLayerCompositor::frameViewDidScroll(const IntPoint&
scrollPosition)
>  {
>      if (m_scrollLayer)
>	   m_scrollLayer->setPosition(FloatPoint(-scrollPosition.x(),
-scrollPosition.y()));
> @@ -1039,6 +1039,9 @@ bool
RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame() const
>      // On non-Mac platforms, let compositing propagate for all iframes.
>      return true;
>  #else
> +    if (!m_renderView->frameView()->platformWidget())
> +	   return true;
> +
Could you add a comment about why we check for a null platform widget here?

Looks fine otherwise!