[webkit-reviews] review denied: [Bug 42592] PopupMenu refactoring in preparation to WebKit2 : [Attachment 62570] rebase
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 26 09:40:15 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 42592: PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
Attachment 62570: rebase
https://bugs.webkit.org/attachment.cgi?id=62570&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/page/ChromeClient.h:132
+ virtual PassRefPtr<SelectUIClient>
createSelectUIClient(PopupMenuClient*) const = 0;
I think it would be better to name these methods:
createSelectPopupMenu
createSearchPopupMenu
And, these should each take a PopupMenuClient* and return a
PassRefPtr<PopupMenu>.
PopupMenu should be made an abstract interface.
If you look at PopupMenu.h today, it is a mess of #ifdefs. There is very
little
that is shared between the ports other than the interface itself. So, making
PopupMenu be an interface makes sense. The concrete class should be renamed:
PopupMenuWin, PopupMenuChromium, etc.
Doing so has a couple other nice properties:
1- It avoids introducing new terminology ("what is a select ui client?")
2- It avoids a dependency from WebCore/platform on WebCore/page
More information about the webkit-reviews
mailing list