[webkit-reviews] review denied: [Bug 42811] Geolocation preemptive permissions policy is buggy : [Attachment 62572] patch

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has denied Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 42811: Geolocation preemptive permissions policy is buggy
https://bugs.webkit.org/show_bug.cgi?id=42811

Attachment 62572: patch
https://bugs.webkit.org/attachment.cgi?id=62572&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
> ChangeLog
> +	     No new test content added
I think this warrants a new test. Unfortunately I think that requires a fix to
the Mac LayoutTestController which is being done in Bug 40002. I'll try to get
that bug fixed soon.

> Geolocation.cpp: 415
> page->geolocationController()->addObserver(this);
This should be in the above loop. Can you also add a FIXME to pass options to
the client, as at line 635.

> Geolocation.cpp: 417
> // TODO: Handle startUpdate() for non-client based implementations using
pre-emptive policy
This patch should just fix this bug - the problems with the existing code.
Let's leave adding the new code for !CLIENT_BASED && PREEMPT for Bug 42027.