[webkit-reviews] review granted: [Bug 40909] Support WTF::Vector pretty printer for GDB 7 : [Attachment 62563] support-wtf-vector-typo-fixed-and-add-comments

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 40909: Support WTF::Vector pretty printer for GDB 7
https://bugs.webkit.org/show_bug.cgi?id=40909

Attachment 62563: support-wtf-vector-typo-fixed-and-add-comments
https://bugs.webkit.org/attachment.cgi?id=62563&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good. Thanks for your update!

> I don't think it is worth hiding 'pretty_printer_dict' from global scope.
'pretty_printer_dict' is global, but that is global only within this module.
I'd like to leave that as is because that won't conflict any variables defined
in other modules.

I still like not to use global variables because I was a bit surprised this
code seemed to use a variable without declaration. At first, I guessed
pretty_printers_dict is something special in GDB extensions. But it's OK as is.