[webkit-reviews] review granted: [Bug 42905] Implement OpenGLES2 helper classes. : [Attachment 62505] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 42905: Implement OpenGLES2 helper classes.
https://bugs.webkit.org/show_bug.cgi?id=42905

Attachment 62505: Patch
https://bugs.webkit.org/attachment.cgi?id=62505&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/platform/graphics/chromium/GLES2Canvas.cpp:211
 +	m_stateStack.removeLast();
debug assert that there is a last to remove?

WebCore/platform/graphics/chromium/GLES2Texture.cpp:126
 +  };
nit: no semi-colon on the closing bracket of a namespace

WebCore/platform/graphics/chromium/GLES2Texture.h:43
 +	~GLES2Texture();
nit: consider making the destructor private and make RefCounted<GLES2Texture>
be a friend.
that way someone cannot accidentally delete a GLES2Texture pointer.

WebCore/platform/graphics/chromium/GLES2Texture.h:59
 +  };
nit: no semi-colon on the closing bracket of a namespace


R=me w/ these nits fixed