[webkit-reviews] review granted: [Bug 42937] splitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned up : [Attachment 62515] fixed references and pointers (space before &/*)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 25 19:35:46 PDT 2010


Kent Tamura <tkent at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 42937: splitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned
up
https://bugs.webkit.org/show_bug.cgi?id=42937

Attachment 62515: fixed references and pointers (space before &/*)
https://bugs.webkit.org/attachment.cgi?id=62515&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>

> -
> -bool ApplyStyleCommand::splitTextElementAtEndIfNeeded(const Position &start,
const Position &end)
> +    

nit: Do not add whitespace at the end of line.

>  }
> -
> +    
>  static bool areIdenticalElements(Node *first, Node *second)

ditto.


More information about the webkit-reviews mailing list