[webkit-reviews] review requested: [Bug 42941] Redo fails after text node is split by SplitTextNodeCommand : [Attachment 62531] Added doReapply to SplitTextNodeCommand (asserts parent node is editable)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 25 14:05:32 PDT 2010
Ryosuke Niwa <rniwa at webkit.org> has asked for review:
Bug 42941: Redo fails after text node is split by SplitTextNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=42941
Attachment 62531: Added doReapply to SplitTextNodeCommand (asserts parent node
is editable)
https://bugs.webkit.org/attachment.cgi?id=62531&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
Instead of bailing out of doApply when the parent node is not editable, assert
that the parent node is editable because callee shouldn't be calling
SplitTextNode on a non-editable text node.
More information about the webkit-reviews
mailing list