[webkit-reviews] review granted: [Bug 42945] [Qt] getImageData(): Single-pass RGB->BGR and un-premultiplication : [Attachment 62523] Proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 42945: [Qt] getImageData(): Single-pass RGB->BGR and un-premultiplication
https://bugs.webkit.org/show_bug.cgi?id=42945

Attachment 62523: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=62523&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebCore/platform/graphics/qt/ImageBufferQt.cpp:178
 +	QImage image =
imageData.m_pixmap.toImage().convertToFormat(QImage::Format_ARGB32_Premultiplie
d);
I think it would be nice with a comment here why you disconsider the bool
multiplied, people might think that is an error in the future.

WebCore/platform/graphics/qt/ImageBufferQt.cpp:212
 +		    pixel = ((pixel << 16) & 0xff0000) | ((pixel >> 16) & 0xff)
| (pixel & 0xff00ff00);
Maybe you should explain the RGB->BGR swapping here, just like a little comment