[webkit-reviews] review requested: [Bug 42938] Output more descriptive PASS messages for list layout tests : [Attachment 62514] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 42938: Output more descriptive PASS messages for list layout tests
https://bugs.webkit.org/show_bug.cgi?id=42938

Attachment 62514: Patch
https://bugs.webkit.org/attachment.cgi?id=62514&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I thought it would be easier to review the changes to the files
LayoutTests/fast/lists/resources/dump-list.js,
LayoutTests/fast/lists/w3-css3-list-styles-alphabetic-expected.txt, and
LayoutTests/fast/lists/w3-css3-list-styles-numeric-expected.txt in a separate
patch than to post an updated patch for Bug #42803.

My plan is to land Bug #42803 (as is). Then this bug (Bug #42938). Then,
eventually Bug #36734.

I am open to suggestions on how to make the PASS messages more descriptive.
Notice, we only output the PASS message if the list item marker matches the
list item text for each <li> in the list.

Without loss of generality, consider the following list:

<ol start="5">
    <li>5</li>
    <li>6</li>
</ol>

Then the PASS message would be: "PASS list markers matched list items for list
that starts from 5 and has 2 items."

I thought to output the PASS message on a per list basis instead of a per <li>
basis so as to make the output easier to read (since there would be less lines
to read).