[webkit-reviews] review requested: [Bug 42036] svn-unapply warns of uninitialized variable when unapplying a patch that describes an svn move operation : [Attachment 62508] Alternative Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 42036: svn-unapply warns of uninitialized variable when unapplying a patch
that describes an svn move operation
https://bugs.webkit.org/show_bug.cgi?id=42036

Attachment 62508: Alternative Patch
https://bugs.webkit.org/attachment.cgi?id=62508&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I noticed that svn-apply initializes $patch to "" for a similar issue
<http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/svn-apply?rev=59344#L
300>, so I came up with this alternative patch.

I am open to suggestions if we should use the first patch
<https://bugs.webkit.org/attachment.cgi?id=61168&action=edit> or this patch or
some other patch to resolve this bug. The first patch has a bit more
specificity in that it checks for the existence of the key copiedFromPath,
which always exists if the diff represents a svn copy/move operation.