[webkit-reviews] review requested: [Bug 42387] SVG - stroke-width:0 bug with stroke other than "none" : [Attachment 62465] stroke-width:0 fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 23 15:11:47 PDT 2010


Fady Samuel <fsamuel at chromium.org> has asked  for review:
Bug 42387: SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387

Attachment 62465: stroke-width:0 fix
https://bugs.webkit.org/attachment.cgi?id=62465&action=review

------- Additional Comments from Fady Samuel <fsamuel at chromium.org>
So the initial patch broke some already flaky layout tests. It turns out fixing
this bug revealed a couple of others. First, the video controls in the video
element were not rendered correctly as the stroke-width was not specified.
Secondly, stroke-width defaults to 0, this patch defaults it to 1 now as the
spec describes. 

This bug corresponds to Issue 15461 on chromium.org:

http://code.google.com/p/chromium/issues/detail?id=15461

I may be missing some more layout tests. There may need to be more rebaselining
in the gtk platform and in the windows platforms. My chromium-mac/mac platforms
were baselined on Snow Leopard, this may or may not be what is expected.


More information about the webkit-reviews mailing list