[webkit-reviews] review denied: [Bug 40197] Enhance the hit testing to take a rectangle instead of a point : [Attachment 62453] patch v6 - feature + tests

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Antonio Gomes <tonikitoo at webkit.org>'s
request for review:
Bug 40197: Enhance the hit testing to take a rectangle instead of a point
https://bugs.webkit.org/show_bug.cgi?id=40197

Attachment 62453: patch v6 - feature + tests
https://bugs.webkit.org/attachment.cgi?id=62453&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
"void static dumpHitTestResult(const HitTestResult& result)"

I really don't like this function sitting in Document.	It has nothing to do
with Document.	I'd prefer it either be removed or put in more of a debugging
file (if it's a bit like render tree dumping especially).  It really seems to
me like it should just be removed, especially if nodesFromRect is testable via
layout tests.

Let's use 0,0 as the default value for padding instead of -1,-1 and make
rect-based hit testing be activated if either value of padding is > 0 (rather
than >= 0).  We don't want to fall into rect-based hit testing because somebody
passed 0 values for padding in to these functions.

Everything else looks good to me.