[webkit-reviews] review canceled: [Bug 40197] Enhance the hit testing to take a rectangle instead of a point : [Attachment 62313] patch v5 - feature + tests

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has canceled Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 40197: Enhance the hit testing to take a rectangle instead of a point
https://bugs.webkit.org/show_bug.cgi?id=40197

Attachment 62313: patch v5 - feature + tests
https://bugs.webkit.org/attachment.cgi?id=62313&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Changes from v5:

1) it avoids copying unnecessery class members by not using the copy
constructor when applicable. It uses constructions like:

HitTestResult tempResult(result.point(), result.padding());
instead of:
HitTestResult tempResult(result); <- copy constructor

2) On assignment and copy constructor, the ListHashSet only gets copied if it
is a rect based hit test, for performance reasons.

It specially matches the concern expressed in comment #38.

Again for the comon case of non