[webkit-reviews] review granted: [Bug 19208] Inspector should remember resources sorting set by the user : [Attachment 62406] [PATCH] ChangeLog message augmented

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 19208: Inspector should remember resources sorting set by the user
https://bugs.webkit.org/show_bug.cgi?id=19208

Attachment 62406: [PATCH] ChangeLog message augmented
https://bugs.webkit.org/attachment.cgi?id=62406&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Thanks!

> +    WebInspector.applicationSettings.resourcesSortOptions = {timeOption:
this._selectedOptionNameForGraph(this.timeGraphItem), sizeOption:
this._selectedOptionNameForGraph(this.sizeGraphItem)};
> +    WebInspector.applicationSettings.installSetting("resourcesSortOptions",
"resources-sort-options", {timeOption: "responseTime", sizeOption:
"transferSize"});

I thought our style was to put spaces around the braces
for JavaScript object literals. So instead of:

  {a:1, b:1}

I think we normally go with:

  { a:1, b:1 }

But I just did a search and found we do a lot of both,
so I guess it doesn't matter either way. But it would
be good to settle on a style for literals.