[webkit-reviews] review denied: [Bug 40272] The 2d.imageData.object.round and 2d.imageData.object.wrap canvas tests are failing : [Attachment 62139] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 23 08:52:38 PDT 2010


Darin Adler <darin at apple.com> has denied Helder Correia
<heldercorreia at codeaurora.org>'s request for review:
Bug 40272: The 2d.imageData.object.round and 2d.imageData.object.wrap canvas
tests are failing
https://bugs.webkit.org/show_bug.cgi?id=40272

Attachment 62139: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=62139&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good. As per our discussion, please add a regression test and a comment
making clear why "long long" is needed in setIndex.


More information about the webkit-reviews mailing list