[webkit-reviews] review requested: [Bug 41792] [WINCE] Implement TCSpinLock : [Attachment 62428] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 41792: [WINCE] Implement TCSpinLock
https://bugs.webkit.org/show_bug.cgi?id=41792

Attachment 62428: Patch
https://bugs.webkit.org/attachment.cgi?id=62428&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #3)
> I don't understand how this code will be compiled for WinCE. The first branch
of this #if/#elif chain is:
> 
> #if (CPU(X86) || CPU(X86_64) || CPU(PPC)) && (COMPILER(GCC) ||
COMPILER(MSVC))
> 
> Will WinCE not match that condition?
CPU(ARM)

> > +	 LONG m_lockword;
> 
> I think m_lockword is supposed to be a volatile LONG.

No, otherwise you get "convert parameter 1 from 'volatile LONG *' to 'LPLONG'"