[webkit-reviews] review granted: [Bug 42888] [WINCE] Buildfix for GraphicsContext : [Attachment 62410] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 42888: [WINCE] Buildfix for GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=42888

Attachment 62410: Patch
https://bugs.webkit.org/attachment.cgi?id=62410&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
In the future, it would be helpful for you to use svn-create-patch rather than
plain "svn diff" to create your patches. The former does a few things to make
the patches slightly easier to read (like putting function names above each
chunk).

> @@ -1268,7 +1268,7 @@
>      
>      IntRect dstRect = fillRect;
>      
> -    dstRect.move(shadowSize);
> +    dstRect.move(shadowSize.width(), shadowSize.height());

Is truncating to int really the right thing to do here?

r=me, but I'll wait for an answer before marking this cq+.