[webkit-reviews] review granted: [Bug 42883] Chromium DevTools: migrate from utility context-based injected script dispatch to upstream schema. : [Attachment 62414] [PATCH] Tests fixed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 23 04:54:59 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 42883: Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
https://bugs.webkit.org/show_bug.cgi?id=42883

Attachment 62414: [PATCH] Tests fixed.
https://bugs.webkit.org/attachment.cgi?id=62414&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/front-end/InjectedScriptAccess.js:40
 +	else {
You don't need "else" since you return from the "if" branch.

WebCore/bindings/v8/ScriptProfile.cpp:43
 +	v8::HandleScope scope;
This shouldn't be necessary, please check.


More information about the webkit-reviews mailing list