[webkit-reviews] review granted: [Bug 42873] Web Inspector: error info propagation in InspectorBackendDispatch should be improved : [Attachment 62398] Patch

[bugzilla-daemon at webkit.org]

Ilya Tikhonovsky <loislo at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 42873: Web Inspector: error info propagation in InspectorBackendDispatch
should be improved
https://bugs.webkit.org/show_bug.cgi?id=42873

Attachment 62398: Patch
https://bugs.webkit.org/attachment.cgi?id=62398&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>

WebCore/inspector/CodeGeneratorInspector.pm:245
 +	push(@function, "    if (args->length() != " . $expectedParametersCount
. ") {");

can be simplified a bit.
push(@function, "    if (args->length() != $expectedParametersCount) {");


WebCore/inspector/CodeGeneratorInspector.pm:246
 +	push(@function, "	 *exception = String::format(\"Wrong number of
parameters: %d (expected: $expectedParametersCount)\", args->length());");
It would be better to also print the parameter name.