[webkit-reviews] review denied: [Bug 42254] ThreadSpecific (QThreadStorage) should not be deleted : [Attachment 61512] patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 42254: ThreadSpecific (QThreadStorage) should not be deleted
https://bugs.webkit.org/show_bug.cgi?id=42254

Attachment 61512: patch
https://bugs.webkit.org/attachment.cgi?id=61512&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
There is no requirement that the first client of JSC be a browser, nor that
alternate threads be workers.  JSC has multiple mac clients that use jsc off
the main thread, and CFNetwork uses JSC for PAC files, so 
"// This function surely called from the main thread first,"
Is incorrect.

If you really felt that this should be persistent you would either have to add
a lock on stackGuards or push it into initializeThreading (or whatever that
function is called).

That said I don't understand why Qt has a requirement that thread specific data
not ever be removed -- this code seems to work with pthreads, and with windows'
thread specific storage so i'm not sure why qt doesn't.