[webkit-reviews] review denied: [Bug 40909] Support WTF::Vector pretty printer for GDB 7 : [Attachment 59338] support-wtf-vector-fix-style

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 40909: Support WTF::Vector pretty printer for GDB 7
https://bugs.webkit.org/show_bug.cgi?id=40909

Attachment 59338: support-wtf-vector-fix-style
https://bugs.webkit.org/attachment.cgi?id=59338&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
r- for minor issues.

WebKitTools/gdb/wtf.py:98
 +  build_pritty_printers_dict()
pretty

WebKitTools/gdb/wtf.py:96
 +  pretty_printers_dict = {}
It would be better not to use a global variable? Maybe

pretty_printers = build_pretty_printers()
gdb.pretty_printers.append(lambda val: lookup_function(pretty_printers, val))

(I'm not 100% sure if it's OK to pass lambda to gdb.pretty_printers though)


WebKitTools/gdb/wtf.py:43
 +	"Print a WTF::Vector"
Could you add a document about how each members will be used? I guess both
children and to_string will be called for GDB's p command when display_hint is
'array'? Maybe putting URL for GDB's python document would be nice.

WebKitTools/gdb/wtf.py:59
 +		elt = self.item.dereference()
I think element would be better. Usually WebKit code doesn't like
abbreviations.