[webkit-reviews] review denied: [Bug 42827] Use the js-execute-active(entered) Frame to check the user gesture of page instead of checking the top frame : [Attachment 62371] patch v1, adding a getActiveFrame method to get current active JS execute frame

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Johnny Ding <jnd at chromium.org>'s
request for review:
Bug 42827: Use the js-execute-active(entered) Frame to check the user gesture
of page instead of checking the top frame
https://bugs.webkit.org/show_bug.cgi?id=42827

Attachment 62371: patch v1, adding a getActiveFrame method to get current
active JS execute frame
https://bugs.webkit.org/attachment.cgi?id=62371&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/bindings/js/ScriptController.cpp:306
 +	return exec ? toDynamicFrame(exec) : 0;
This is dangerous.  The lexical frame is most likely to be the active frame. 
The dynamic frame isn't used for very much beyond user gesture.

WebCore/loader/FrameLoader.cpp:1133
 +	Frame* enteredFrame = frame->script()->getActiveFrame();
We don't use the term "enteredFrame" outside the V8 bindings.

WebCore/loader/FrameLoader.cpp:1137
 +	return
enteredFrame->script()->processingUserGesture(mainThreadNormalWorld()); //
FIXME: Use pageIsProcessingUserGesture.
This is all way too complicated.  Every call site will need to do this dance. 
Can't we push this junk into the bindings / ScriptController?