[webkit-reviews] review denied: [Bug 42612] DRT should allow test scripts to access WebCore internal states for setup/verification : [Attachment 62260] made the patch smaller to contain only mac port

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 42612: DRT should allow test scripts to access WebCore internal states for
setup/verification
https://bugs.webkit.org/show_bug.cgi?id=42612

Attachment 62260: made the patch smaller to contain only mac port
https://bugs.webkit.org/attachment.cgi?id=62260&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Thanks for doing this. This is a big improvement over needing to implement the
same API many times over. I don't really know JSC APIs well enough to know if
there is a better way to do the inheritance. Someone else will need to review
the code properly. I just have a few naming issues.

I think we should call the new class LayoutTestControllerWebCore though. Just
saying "Core" is too vague (e.g. that could also be JavaScriptCore).

> +    int documentMakerSizeForNode(Node*, ExceptionCode&) const;
> +    String documentMakerStringForNodeAt(Node*, int, ExceptionCode&) const;

Did you mean documentMarker* here?