[webkit-reviews] review denied: [Bug 42304] DeviceOrientation event listeners should never be called synchronously from addEventListener() : [Attachment 61785] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 22 17:05:46 PDT 2010
Ojan Vafai <ojan at chromium.org> has denied Steve Block <steveblock at google.com>'s
request for review:
Bug 42304: DeviceOrientation event listeners should never be called
synchronously from addEventListener()
https://bugs.webkit.org/show_bug.cgi?id=42304
Attachment 61785: Patch
https://bugs.webkit.org/attachment.cgi?id=61785&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Even if you can't add layout tests you should add manual tests that can be
converted to layout tests once LayoutTestController supports DeviceOrientation.
Also, it would be good if the ChangeLog description could point to the bugs for
adding the necessary support to LayoutTestController.
More information about the webkit-reviews
mailing list