[webkit-reviews] review granted: [Bug 37981] implement getData('text/html') for webkit win : [Attachment 62124] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 22 16:36:11 PDT 2010


Ojan Vafai <ojan at chromium.org> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 37981: implement getData('text/html') for webkit win
https://bugs.webkit.org/show_bug.cgi?id=37981

Attachment 62124: Patch
https://bugs.webkit.org/attachment.cgi?id=62124&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
> +String urlToMarkup(const KURL& url, const String& title);

Was this accidental? I don't see it used anywhere.

> > WebCore/platform/win/ClipboardUtilitiesWin.cpp:466
> >  +	    if (SUCCEEDED(data->GetData(htmlFormat(), &store))) {
> > This and the following line seem to be identical to getCFHTML. Can you
change to call the helper function?
> 
> They're the same up until the call to extactMarkupFromCFHTML.  I could
refactor the 5 lines before that into a function, but I'm not sure there's much
benefit.

I almost always think it's worth pulling these sorts of things into a static
helper function. But your call. If there's a bug in this in the future, it only
needs to be fixed in one place.


More information about the webkit-reviews mailing list