[webkit-reviews] review denied: [Bug 30802] Implement automatic switching to slider-vertical : [Attachment 56812] Patch (rev.3)

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 30802: Implement automatic switching to slider-vertical
https://bugs.webkit.org/show_bug.cgi?id=30802

Attachment 56812: Patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=56812&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
> +    if (style->height().isFixed() && style->width().isFixed() &&
style->height().value() > style->width().value())

This won't work for percentage heights/widths, will it? What about the
intrinsic width? Can you add that case to your test case? I'm not sure about
this, but I think you might want to look at style->paddingBox().