[webkit-reviews] review requested: [Bug 42767] [Windows] Home hey doesn't work in first DIV inside a TABLE : [Attachment 62345] fixed per ojan's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 22 14:56:33 PDT 2010
Ryosuke Niwa <rniwa at webkit.org> has asked for review:
Bug 42767: [Windows] Home hey doesn't work in first DIV inside a TABLE
https://bugs.webkit.org/show_bug.cgi?id=42767
Attachment 62345: fixed per ojan's comments
https://bugs.webkit.org/attachment.cgi?id=62345&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #11)
> > What if I've already called setNodeToDump and just want to pass-in the
description? Then I have to specify the node again in order to dump a subtree.
So I added that else clause to allow the description being passed through
opt_node.
>
> Yikes. Having the arguments swap places like that is too confusing to be
worth it. You can just do Markup.dump(null, "foo").
Ok, removed.
More information about the webkit-reviews
mailing list