[webkit-reviews] review granted: [Bug 42829] Code Generator: Should be able to generate constants with string and negative number values. : [Attachment 62302] Adds ability to generate string values and negative number values for constants
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 22 12:57:36 PDT 2010
Darin Adler <darin at apple.com> has granted Jessie Berlin <jberlin at webkit.org>'s
request for review:
Bug 42829: Code Generator: Should be able to generate constants with string and
negative number values.
https://bugs.webkit.org/show_bug.cgi?id=42829
Attachment 62302: Adds ability to generate string values and negative number
values for constants
https://bugs.webkit.org/attachment.cgi?id=62302&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + (WebDOMTestObj::):
> +
> + (WebCore::):
> + (WebCore::jsTestObjCONST_VALUE_9):
> + (WebCore::jsTestObjCONST_VALUE_10):
> + (WebCore::jsTestObjCONST_VALUE_11):
> + (WebCore::jsTestObjCONST_VALUE_12):
> + (WebCore::jsTestObjCONST_VALUE_13):
> + (WebCore::jsTestObjCONST_VALUE_14):
> + (WebCore::):
You should take out these useless function name lines.
More information about the webkit-reviews
mailing list