[webkit-reviews] review granted: [Bug 19208] Inspector should remember resources sorting set by the user : [Attachment 62317] [PATCH] Suggested solution

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 19208: Inspector should remember resources sorting set by the user
https://bugs.webkit.org/show_bug.cgi?id=19208

Attachment 62317: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=62317&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Looks good to me. The only thing I have to add is it would be nice to
add a comment or a line in the ChangeLog saying that you store both
the sorting options for the Resources Panel in a single setting, and
its benefit (for Remote debugging its just 1 message to get both settings).

Also, I would argue it might be easier or more future proof to store
settings as JSON strings, instead of strings that need need to be
manually parsed. This case is rather simple, but I think for just a few
more bytes its much more self descriptive and easier to understand.
Consider writing another patch if you agree.

Have you thought about saving other similar settings? Maybe bugs should
be opened up for the following as well, if they aren't already saved:

  - Profiles "Bottom up" / "Top Down".
  - Console filters
  - Resource filters