[webkit-reviews] review denied: [Bug 38050] Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible : [Attachment 58141] Patch and layout test v2

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ben Murdoch
<benm at google.com>'s request for review:
Bug 38050: Form button input elements lacking text in some cases after
switching from visibility:collapse to visibility:visible
https://bugs.webkit.org/show_bug.cgi?id=38050

Attachment 58141: Patch and layout test v2
https://bugs.webkit.org/attachment.cgi?id=58141&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
This is an OK way to do it, but rather than complexificate
adjustStyleDifference(), you could just move this code to RenderStyle::diff(),
and use display() == BOX to detect whether you're dealing with a flexbox.

Be sure to add your code between the last 'return StyleDifferenceLayout' and
the first 'return StyleDifferenceRepaintLayer'.