[webkit-reviews] review denied: [Bug 42804] Enable HTML5 tree builder : [Attachment 62263] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 42804: Enable HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42804

Attachment 62263: Patch
https://bugs.webkit.org/attachment.cgi?id=62263&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LayoutTests/ChangeLog:8
 +	    Update test expectations.
Would be nice to explain the various changes in the ChangeLog.	We certainly
hav that data.

LayoutTests/ChangeLog:10
 +	    * dom/html/level2/html/HTMLIsIndexElement01-expected.txt:
e.g. these fail because there is no longer ever a parser-created <isindex>
element, per HTML5.

LayoutTests/fast/dom/no-elements-expected.txt:1
 +  This tests that the elements noframes, nolayer, noscript and noembed are
created as elements and put in the DOM tree. The elements other than <nolayer>
should not contain any children. If the test is successful, the four messages
below will list 0, 0, 0, and 1 child.
This text needs update, no?

LayoutTests/fast/events/tabindex-focus-blur-all-expected.txt:1
 +  333 focus / 333 blur events dispatched, and should be 337 / 337 PASSED
I don't understand why this is changing?

LayoutTests/fast/forms/datalist-nonoption-child-expected.txt:8
 +  FAIL datalist.firstChild.nodeName should be #text. Was DIV.
And this?

LayoutTests/platform/mac/editing/selection/designmode-no-caret-expected.txt:20
 +  caret: position 0 of child 0 {#text} of body
This is due to text node coalescing?

LayoutTests/platform/mac/fast/events/focusingUnloadedFrame-expected.txt:22
 +	    layer at (0,0) size 8x8
This looks like a quirks/non-quirks mode change.  is this intentional?

I think this is great!	But if we want this reviewed, we need to post more
explanation in the ChnageLog as to why each test is changing.  Certainly it's
difficult for me to review as-is, and probably impossible for anyone else to
review with understanding of what's changing.