[webkit-reviews] review granted: [Bug 42726] Refactor CSSSelector's destructor and make it inline. : [Attachment 62256] refactor-destructor-3

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 42726: Refactor CSSSelector's destructor and make it inline.
https://bugs.webkit.org/show_bug.cgi?id=42726

Attachment 62256: refactor-destructor-3
https://bugs.webkit.org/attachment.cgi?id=62256&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   // rareData must be deleted here.
> +	   delete m_data.m_rareData;

This is not a very good comment. Good comments answer the question "why", while
this just states that the code is needed without giving a reason.

> +	       // We can not delete the owned object(s) by simply calling
delete
> +	       // directory on them. It leads to recursive destrutor calls
which

Typo here: "directory" but it should be "directly".

Typo here: "destrutor" but it should be "destructor".

Instead of "It leads" the sentence should say "That would lead".

review+ because this patch is great except for the comment issues above, but
I'll leave commit-queue on ? until you decide if you want to post another
patch.