[webkit-reviews] review granted: [Bug 42783] Break out "scheme registration" functionality to a SchemeRegistry : [Attachment 62229] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 42783: Break out "scheme registration" functionality to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783

Attachment 62229: Patch
https://bugs.webkit.org/attachment.cgi?id=62229&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
WebCore/platform/SchemeRegistry.cpp:94
 +  
Boo on two names for the same thing. I would rename "localSchemes" to
"localURLSchemes". (Requires a namespace qualification on the return
statement.)

WebCore/platform/SchemeRegistry.cpp:106
 +  
Seems like these fast cases should assert that they're correct. Something like
"ASSERT(localSchemes().contains(X))".

r=me