[webkit-reviews] review denied: [Bug 39493] Touch events do not affect the :active CSS state : [Attachment 62215] Use a typedef as suggested.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 21 12:05:18 PDT 2010
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ben Murdoch
<benm at google.com>'s request for review:
Bug 39493: Touch events do not affect the :active CSS state
https://bugs.webkit.org/show_bug.cgi?id=39493
Attachment 62215: Use a typedef as suggested.
https://bugs.webkit.org/attachment.cgi?id=62215&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
You should use the same type in HitTestRequest, like this:
class HitTestRequest {
public:
enum RequestTypeFlags {
ReadOnly = 1 << 1,
...
};
typedef unsigned HitTestRequestType;
HitTestRequest(HitTestRequestType requestType) ...
private:
HitTestRequestType m_requestType;
}
etc.
More information about the webkit-reviews
mailing list