[webkit-reviews] review granted: [Bug 41295] [Chromium] Add chromium WebMediaPlayer to PlatformMedia : [Attachment 61542] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 21 11:38:31 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Bo Liu
<boliu at chromium.org>'s request for review:
Bug 41295: [Chromium] Add chromium WebMediaPlayer to PlatformMedia
https://bugs.webkit.org/show_bug.cgi?id=41295
Attachment 61542: Patch
https://bugs.webkit.org/attachment.cgi?id=61542&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:77
> + WebCore::PlatformMedia pm =
element->constUnwrap<HTMLMediaElement>()->platformMedia();
nit: no need for WebCore:: prefix in this file since there is a 'using
namespace WebCore'
at the top of the file.
> + WebCore::PlatformMedia pm;
ditto
R=me, but please fix that before
committing.WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:174
More information about the webkit-reviews
mailing list